Fixed cuvs benchmark debug build issue (linker step fail) #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
irina-resh-nvda
added
bug
divyegala
approved these changes
Dec 1, 2025
irina-resh-nvda
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
Contributor
Author
|
/ok to test 8daad14 |
Contributor
Author
|
/ok to test c24f3ee |
Contributor
Author
|
/ok to test de6285b |
cjnolet
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building cuVS benchmarks in Debug mode would fail during linker step with the following (e.g.) message
[ 97%] Built target cuvs_c /usr/bin/ld: ../../libcuvs.so: undefined reference tocuvs::neighbors::hnsw::index::set_ef(int) const'/usr/bin/ld: ../../libcuvs.so: undefined reference to
cuvs::neighbors::hnsw::index<__half>::set_ef(int) const' /usr/bin/ld: ../../libcuvs.so: undefined reference tocuvs::neighbors::hnsw::index::set_ef(int) const'/usr/bin/ld: ../../libcuvs.so: undefined reference to
cuvs::neighbors::hnsw::index<signed char>::set_ef(int) const'An example CMake command:
cmake .. -DCUVS_NVTX=ON -DBUILD_MG_ALGOS=OFF -DBUILD_TESTS=OFF -DBUILD_C_TESTS=OFF -DBUILD_CUVS_BENCH=ON -DCUVS_ANN_BENCH_USE_FAISS_GPU_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_IVF_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_CAGRA=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_IVF_PQ=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_IVF_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_IVF_PQ=OFF -DCUVS_ANN_BENCH_USE_FAISS_CPU_HNSW_FLAT=OFF -DCUVS_ANN_BENCH_USE_FAISS_GPU_CAGRA_HNSW=OFF -DCUVS_ANN_BENCH_USE_CUVS_CAGRA_HNSWLIB=OFF -DCUVS_ANN_BENCH_USE_HNSWLIB=OFF -DCUVS_ANN_BENCH_USE_GGNN=OFF -DCUVS_ANN_BENCH_USE_DISKANN=OFF -DCUVS_ANN_BENCH_USE_CUVS_VAMANA=OFF -DCUVS_ANN_BENCH_USE_CUVS_CAGRA_DISKANN=OFF -DCUVS_ANN_BENCH_USE_CUVS_MG=OFF -DDISABLE_DEPRECATION_WARNINGS=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_CUDA_ARCHITECTURES=80 -DCMAKE_BUILD_TYPE=DebugThe same code would still compile in Release mode (probably due to compile optimisation)
The fix just declares
cuvs::neighbors::hnsw::index::set_ef(int) function as purely virtual.