[FEA] IVF-PQ to Write Flat PQ Codes #1607
Open
+1,136
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
tarang-jain
added
feature request
tarang-jain
changed the title
Contributor
Author
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
tarang-jain
changed the title
Contributor
Author
|
/ok to test dc99bfb |
…with strat pattern
…into ivfpq-flat-codes
Contributor
Author
|
/ok to test f6cf637 |
Contributor
Author
|
/ok to test d9c9b62 |
Member
|
/ok to test 02f4c76 |
…into ivfpq-flat-codes
Contributor
Author
|
/ok to test a5e482b |
tarang-jain
commented
Jan 15, 2026
| uint8_t code = action(in_ix, j); | ||
| if (lane_id == 0) { code_view[j] = code; } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Small optimization opportunity here: We can do the lane_id == 0 check at the very beginning and simply return if that condition is not true. Because the code writing is done only by the thread with lane_id = 0.
Contributor
Author
|
/ok to test 252cfbd |
1 similar comment
Member
|
/ok to test 252cfbd |
@cjnolet, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Member
|
/ok to test 3bf9018 |
Contributor
Author
|
/ok to test 3bf9018 |
… ivfpq-flat-codes
tarang-jain
force-pushed
the
ivfpq-flat-codes
branch
from
3bf9018 to
b5cfc7e
Compare
Contributor
Author
|
/ok to test b5cfc7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings new params to ivf_pq: an option for the user to choose the layout of the ivf lists. The lists can be flat (no interleaving) or interleaved (current default). Flat codes allows building the index in a CPU-compatible format.
[UPDATE as of 12/19/2025]:
After #1278 is merged, we can unify IVF-PQ and PQ API codepaths.
[UPDATE 01/08/2026]:
This PR can be merged before #1278. The flat code-writing can potentially be reverted once #1278 is merged (so we can later use the PQ preprocessing API directly). However that will come naturally as a part if a broader unification of IVF-PQ and PQ codepaths.
[Benchmarks 01/15/2026]:
IVF-PQ Layout Benchmark Results
Dataset: 1,000,000 vectors × 128 dimensions | pq_dim: 32