Add float16 support for CAGRA extend #1620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
Contributor
Author
|
/ok to test 46d53b7 |
Contributor
Author
|
/ok to test d2e7798 |
Contributor
Author
|
/ok to test 8ba5eed |
Member
|
Thanks for spotting and fixing this @lowener. Just for completeness, can you share the increase in binary size that this change causes? Likely not. a blocker, but helps us for tracking to keep that info close to the changes. Thanks! |
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1595
CAGRA support extend for float32, int8, uint8. This PR adds float16. I conserved the commits from the original authors and added some tests on C++ and python sides.