Skip to content

Conversation

@julianmi
Copy link
Contributor

This PR introduces create_numpy_file in the file_io.hpp header. It creates NumPy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. This removes duplicated code in CAGRA ACE in cagra_build.cuh. It addresses one follow-up item of #1486.

CC @tfeher

- Introduces `create_numpy_file` in the file_io.hpp header.
- The function creates numpy files with pre-allocated space and writes the appropriate header based on the specified shape and data type.
- Removes duplicated code.
- Partly addresses rapidsai#1486.
@cjnolet cjnolet moved this from Todo to In Progress in Vector Search, ML, & Data Mining Release Board Jan 5, 2026
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 5, 2026
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julian for simplifying the code. LGTM.

@tfeher
Copy link
Contributor

tfeher commented Jan 15, 2026

/merge

@rapids-bot rapids-bot bot merged commit 1a0a1d4 into rapidsai:main Jan 15, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

3 participants