Add includes for algorithm and rmm/cuda_device #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file uses <algorithm> for std::min and <Rapids RMM> for rmm::available_device_memory, but does not explicitly include them. This can cause issues when compiling with some compilers.
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
cjnolet
added
bug
Member
|
/ok to test f5009e9 |
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
cjnolet
approved these changes
Dec 17, 2025
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix, @maxwbuckley!
Member
|
/ok to test b5d38a0 |
Member
|
/ok to test fff2f77 |
Member
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file uses for std::min and for rmm::available_device_memory, but does not explicitly include them. This can cause issues when compiling with some compilers.