-
Notifications
You must be signed in to change notification settings - Fork 40
Publish unversioned Docker image tags from main branch #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gforsyth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one wonky comment, but otherwise I think this is good to go.
ci/release/update-version.sh
Outdated
| # Primary interface: bash update-version.sh <new_version> [--run-context=main|release] | ||
| # Fallback interface: [RAPIDS_RUN_CONTEXT=main|release] bash update-version.sh <new_version> | ||
| # CLI arguments take precedence over environment variables | ||
| # Defaults to main when no run-context is not specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Defaults to main when no run-context is not specified | |
| # Defaults to main when no run-context is specified |
?
| EOF | ||
| )")"; | ||
| tag="${VERSION:-latest}-${tag}-$(echo "${os}" | tr -d :)"; | ||
| base_tag="${tag}-$(echo "${os}" | tr -d :)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason the tag doesn't have latest in it? That's the usual convention for docker images.
i.e. latest-cpp-nvhpc25.11 is an alias of 26.02-cpp-nvhpc25.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with that. We didn't do that for ci-imgs because latest means something different (the configuration with latest supported CUDA / latest supported Python).
Summary
Closes #645.
This PR splits the image tag into two components:
version: The RAPIDS version (e.g.,26.02)base_tag: The image variant identifier (e.g.,cpp-cuda13.1-ubuntu2404)The full versioned tag is constructed as
${version}-${base_tag}.Changes
.github/actions/devcontainer-json/action.sh: Outputbase_tagandversionseparately instead of a combined tag..github/actions/devcontainer-json/action.yml: Expose bothbase_tagandversionoutputs..github/workflows/build-test-and-push-linux-image.yml:${version}-${base_tag}${base_tag}(main branch only)Example Tags
main26.02-cpp-cuda13.1-ubuntu2404,26.02-cpp-cuda13.1,cpp-cuda13.1-ubuntu2404,cpp-cuda13.1release/26.0226.02-cpp-cuda13.1-ubuntu2404,26.02-cpp-cuda13.1