Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Jan 6, 2026

Summary

Closes #645.

This PR splits the image tag into two components:

  • version: The RAPIDS version (e.g., 26.02)
  • base_tag: The image variant identifier (e.g., cpp-cuda13.1-ubuntu2404)

The full versioned tag is constructed as ${version}-${base_tag}.

Changes

  1. .github/actions/devcontainer-json/action.sh: Output base_tag and version separately instead of a combined tag.

  2. .github/actions/devcontainer-json/action.yml: Expose both base_tag and version outputs.

  3. .github/workflows/build-test-and-push-linux-image.yml:

    • Build images with tag ${version}-${base_tag}
    • Push versioned manifests (always)
    • Push unversioned manifests using ${base_tag} (main branch only)

Example Tags

Branch Tags
main 26.02-cpp-cuda13.1-ubuntu2404, 26.02-cpp-cuda13.1, cpp-cuda13.1-ubuntu2404, cpp-cuda13.1
release/26.02 26.02-cpp-cuda13.1-ubuntu2404, 26.02-cpp-cuda13.1

@bdice bdice requested a review from a team as a code owner January 6, 2026 20:39
@bdice bdice requested review from gforsyth and removed request for a team January 6, 2026 20:39
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one wonky comment, but otherwise I think this is good to go.

# Primary interface: bash update-version.sh <new_version> [--run-context=main|release]
# Fallback interface: [RAPIDS_RUN_CONTEXT=main|release] bash update-version.sh <new_version>
# CLI arguments take precedence over environment variables
# Defaults to main when no run-context is not specified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Defaults to main when no run-context is not specified
# Defaults to main when no run-context is specified

?

EOF
)")";
tag="${VERSION:-latest}-${tag}-$(echo "${os}" | tr -d :)";
base_tag="${tag}-$(echo "${os}" | tr -d :)";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason the tag doesn't have latest in it? That's the usual convention for docker images.

i.e. latest-cpp-nvhpc25.11 is an alias of 26.02-cpp-nvhpc25.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with that. We didn't do that for ci-imgs because latest means something different (the configuration with latest supported CUDA / latest supported Python).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish unversioned Docker image tags from main branch

3 participants