move more shared code into scripts #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jameslamb
force-pushed
the
use-scripts
branch
from
b849bf3 to
6d6f0f6
Compare
jameslamb
changed the title
bdice
approved these changes
Jan 20, 2026
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #832
Follow-up to #836 (comment)
In #836, this repo's dependency on https://github.com/rapidsai/ci-imgs was removed by replacing
FROM rapidsai/miniforge-cudawith the inline contents of theDockerfileused to produce that image. That introduced a lot of duplication between the Dockerfiles there.This proposes reducing much of that duplication by moving shared code into scripts that are mounted in at build time.