RSN for conda package `legacy` labelling by gforsyth · Pull Request #570 · rapidsai/docs

gforsyth · 2025-01-27T16:48:25Z

RSN for moving select conda packages behind a new legacy label concurrent with the v25.04 release.

I wasn't sure whether to note the notice_rapids_version as the version where
this change takes place (25.04) or the versions impacted by the change
(<=23.02). I think <=23.02 makes more sense and I've written it as such, but
happy to change things around.

xref rapidsai/build-planning#84

vercel · 2025-01-27T16:48:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Apr 9, 2025 5:45pm

netlify · 2025-01-27T16:51:40Z

✅ Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`3fce008`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rapids-ai/deploys/67f6b1cce004510008c53ba0
😎 Deploy Preview	https://deploy-preview-570--docs-rapids-ai.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bdice · 2025-01-28T17:24:09Z

_notices/rsn0042.md

+
+RAPIDS will move certain older conda packages in the `rapidsai` conda channel
+under a new label: `legacy`. These packages will still be available by appending
+`--label legacy` to installation and search commands.


I'm a little unclear on this. It looks like --label is used when uploading, but for users to install, they need something like --channel rapidsai --channel rapidsai/label/legacy. Does that sound correct?

See https://docs.anaconda.com/anacondaorg/user-guide/work-with-labels/#testing-the-discoverability-of-the-package

Yup, thanks for catching that @bdice !

_notices/rsn0042.md

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

bdice

Looks good! One small suggestion and one question.

_notices/rsn0042.md

bdice · 2025-01-28T19:38:56Z

_notices/rsn0042.md

+All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to
+work without any user intervention.
+
+This change will occur concurrently with the release of RAPIDS `v25.04`.


Just checking: We will be able to test strict channel priority in our CI before the 25.04 release, right? I want to be sure we minimize the risk of breaking recent releases (25.02 / 25.04) during this change.

We'll be able to test 25.02 once all of those packages are released using the same method I tested the previous releases with. Regarding 25.04, we can also release all of those packages, test, then move the selected older packages under the legacy label, or we can move them under the label, see if it works, and then undo the labeling if it breaks.

If 25.02 works, I'd feel confident moving the packages straight to the label for 25.04, and that would let us accurately advertise strict channel priority for the new install instructions.

That's helpful. What about enabling strict priority in our CI for PR & nightly builds/tests, though? It sounds like you're discussing the user experience that we expect after the release is complete.

We can't really enable them for CI until we move the older packages under legacy. The conda-metachannel package is quite brittle at this point and I don't think we want that spun up as part of our CI

Does that mean we will make the legacy label along with the 25.04 release, and then enable strict priority in our CI during development for 25.06?

We can't really enable them for CI until we move the older packages under legacy

Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.

Or said another way... if we're saying this -c rapidsai/label/legacy is only necessary for releases before RAPIDS v23.04, then I'd expect to be able to use strict channel priority with RAPIDS 25.04 today.

(sorry if I'm re-litigating things that have already been discussed, feel free to just respond with links to things I should go read)

You're asking a good question. I think the only confusing part here is timing.

We can't enable strict channel priority until we move "legacy" packages (needed for releases prior to 23.04) to the legacy label. There are packages like datashader that are implicated here.

We plan to move things to the legacy label when 25.04 is released. Then we can enable strict priority in 25.06.

However, there is a path where we enable strict priority gradually in each repo's CI, which I think we could start in 25.04. It just won't work for every repo until after the "legacy" move occurs with the 25.04 release.

Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.

channel priority doesn't consider versions -- if there is ANY version of a package in a higher priority channel, that is the only channel that gets considered for that package. because we have (especially) a patched version of datashader (although there are other problem packages) in rapidsai, most of our solves won't work because it'll see datashader in rapidsai but the single version in rapidsai won't satisfy the current dependency requirements and the solve will fail.

ahhhhhhh ok, thank you both for explaining. Ok then this makes sense to me as-is.

Agree with @bdice that it'd be really helpful to try to enable this repo-by-repo within the 25.04 cycle, to hopefully prevent accidental introduction of even more things that complicate the move to strict channel priority. And because it's a solution to the "did not install the package built in CI" problem: rapidsai/build-planning#14 (comment)

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

_notices/rsn0042.md

jameslamb

Coming here to review based on @jakirkham 's suggestion in rapidsai/build-planning#14 (comment)

I'm leaving a blocking review because a couple of these have to be fixed (like the RSN number).

Can you also please update this to latest main? There are some new commits there since the last time this was modified.

_notices/rsn0042.md

jameslamb · 2025-03-04T16:28:19Z

_notices/rsn0042.md

+All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to
+work without any user intervention.
+
+This change will occur concurrently with the release of RAPIDS `v25.04`.


We can't really enable them for CI until we move the older packages under legacy

Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.

Or said another way... if we're saying this -c rapidsai/label/legacy is only necessary for releases before RAPIDS v23.04, then I'd expect to be able to use strict channel priority with RAPIDS 25.04 today.

(sorry if I'm re-litigating things that have already been discussed, feel free to just respond with links to things I should go read)

_notices/rsn0042.md

…/docs into channel_priority_notice

gforsyth · 2025-03-04T17:48:20Z

Thanks for the suggestions and fixes @jameslamb ! Pushed up all of those and merged in main

jameslamb

Changes look good to me and all my concerns have been addressed. Thank you for moving this forward!

_notices/rsn0044.md

bdice

Looks good to me. This has two approvals and needs to be published with the 25.04 release so I will merge it.

jakirkham

Thanks Gil for all of your hard work here and everyone who helped review! 🙏

Looking forward to having strict channel priority available for users in RAPIDS 25.04 🥳

_notices/rsn0044.md

gforsyth requested a review from a team as a code owner January 27, 2025 16:48

vercel bot deployed to Preview January 27, 2025 16:49 View deployment

Add notice for conda package legacy labelling

e20ea8c

gforsyth force-pushed the channel_priority_notice branch from def31c7 to e20ea8c Compare January 27, 2025 18:38

vercel bot deployed to Preview January 27, 2025 18:39 View deployment

bdice reviewed Jan 28, 2025

View reviewed changes

_notices/rsn0042.md Outdated Show resolved Hide resolved

Update _notices/rsn0042.md

e5bbcc6

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

vercel bot deployed to Preview January 28, 2025 17:38 View deployment

Use correct label command

ba89cba

vercel bot deployed to Preview January 28, 2025 17:40 View deployment

bdice approved these changes Jan 28, 2025

View reviewed changes

Update _notices/rsn0042.md

844022d

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

vercel bot deployed to Preview January 28, 2025 19:43 View deployment

bdice reviewed Jan 28, 2025

View reviewed changes

_notices/rsn0042.md Outdated Show resolved Hide resolved

Remove blank line

2417de8

vercel bot deployed to Preview January 28, 2025 19:44 View deployment

jakirkham mentioned this pull request Mar 4, 2025

Use strict channel priority in test phase rapidsai/build-planning#14

Closed

raydouglass requested a review from jameslamb March 4, 2025 16:42

jameslamb requested changes Mar 4, 2025

View reviewed changes

bdice requested a review from jameslamb March 4, 2025 17:26

gforsyth added 4 commits March 4, 2025 12:38

rename file

5259665

Merge branch 'main' into channel_priority_notice

2f49e64

address review comments

15ebde2

Merge branch 'channel_priority_notice' of https://github.com/gforsyth…

acb3ac1

…/docs into channel_priority_notice

vercel bot deployed to Preview March 4, 2025 17:45 View deployment

jameslamb approved these changes Mar 4, 2025

View reviewed changes

bdice mentioned this pull request Mar 31, 2025

Add RSN about deprecation of cuml-cpu. #586

Merged

Rename to RSN 44

2f961fc

vercel bot deployed to Preview April 9, 2025 17:37 View deployment

Merge branch 'main' into channel_priority_notice

1b5756d

vercel bot deployed to Preview April 9, 2025 17:39 View deployment

bdice reviewed Apr 9, 2025

View reviewed changes

_notices/rsn0044.md Outdated Show resolved Hide resolved

Update dates

e8e6569

vercel bot deployed to Preview April 9, 2025 17:40 View deployment

bdice approved these changes Apr 9, 2025

View reviewed changes

jakirkham approved these changes Apr 9, 2025

View reviewed changes

bdice reviewed Apr 9, 2025

View reviewed changes

_notices/rsn0044.md Outdated Show resolved Hide resolved

bdice added 2 commits April 9, 2025 12:43

Small updates to fix RSN 42 status and formatting.

da941a9

Update notice status

3fce008

bdice approved these changes Apr 9, 2025

View reviewed changes

vercel bot deployed to Preview April 9, 2025 17:45 View deployment

bdice merged commit 786dc8c into rapidsai:main Apr 9, 2025
2 checks passed

Conversation

gforsyth commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-rapids-ai ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bdice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bdice Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bdice Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gforsyth Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jameslamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gforsyth commented Mar 4, 2025

Uh oh!

jameslamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bdice left a comment

Choose a reason for hiding this comment

Uh oh!

jakirkham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gforsyth commented Jan 27, 2025 •

edited

Loading

vercel bot commented Jan 27, 2025 •

edited

Loading

netlify bot commented Jan 27, 2025 •

edited

Loading

bdice Jan 28, 2025 •

edited

Loading

bdice Mar 4, 2025 •

edited

Loading

gforsyth Mar 4, 2025 •

edited

Loading