Add streaming benchmark validator #760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
TomAugspurger
commented
Dec 18, 2025
TomAugspurger
added
non-breaking
Contributor
Author
|
One challenge with running this in CI is the data. We could use |
Contributor
Author
|
/ok to test 4093bf2 |
TomAugspurger
commented
Jan 2, 2026
bdice
requested changes
Jan 5, 2026
| - ucxx==0.48.*,>=0.0.0a0 | ||
| - valgrind | ||
| - pip: | ||
| - tpchgen-cli |
Contributor
There was a problem hiding this comment.
We might want to help contribute conda-forge packages of this.
gforsyth
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CLI validator for our streaming benchmarks. Our expected results come from running a SQL query against the data with DuckDB. The actual results comes from running the C++ binary.
488c8a7 has the validator changes.
2fc29d3 is a preliminary commit that updates our pre-commit config to validate our python files under
ci/, along with the changes to get the current scripts passing.