Skip to content

Remove bridge infrastructure and device_memory_resource #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdice merged 4 commits into from
Mar 25, 2026
Merged

Remove bridge infrastructure and device_memory_resource #2324

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d1e1ee
Remove device_memory_resource and DMR bridge infrastructure
bdice Mar 18, 2026
7f2b7f1
Make get_property constexpr across tests, benchmarks, and thrust_allo…
bdice Mar 25, 2026
d1bc7fc
Rebalance memory usage
bdice Mar 25, 2026
9888ec0
Run SYSTEM_MR_TEST exclusively to prevent cudaMemGetInfo flakiness
bdice Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cpp/benchmarks/utilities/simulated_memory_resource.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <rmm/aligned.hpp>
#include <rmm/detail/error.hpp>
#include <rmm/detail/export.hpp>
#include <rmm/detail/format.hpp>

#include <cuda/memory_resource>
Expand Down Expand Up @@ -112,8 +111,8 @@ class simulated_memory_resource final {
bool operator==(simulated_memory_resource const&) const noexcept { return true; }
bool operator!=(simulated_memory_resource const&) const noexcept { return false; }

RMM_CONSTEXPR_FRIEND void get_property(simulated_memory_resource const&,
cuda::mr::device_accessible) noexcept
constexpr friend void get_property(simulated_memory_resource const&,
cuda::mr::device_accessible) noexcept
{
}

Expand Down
Loading
Loading