Skip to content

Conversation

@lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 9, 2024

Basic Fix - Checks for:

  • Is Array (returns false - not supported)
  • Is Integer (returns an integer of value)
  • Is Float (returns the float of value)
  • All values being numeric, converts to float, checks if should be int or float
    Otherwise returns false.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 4f09e07 into rappasoft:development Nov 9, 2024
@lrljoe lrljoe mentioned this pull request Nov 10, 2024
lrljoe added a commit that referenced this pull request Nov 10, 2024
## [v3.5.1] - 2024-11-09
### Bug Fixes
- Fix NumberFilter bug for string values by @lrljoe in #2034
- Fixes for Filter Pills - Split blades, and ensure invalid filter alues are removed by @lrljoe in #2035
@lrljoe lrljoe mentioned this pull request Nov 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant