Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 17, 2024

This PR requires an "npm run build" if bundling.

This updates the BooleanFilter to ensure that it respects internal behaviours, and removes the current injection of $wire into the Alpine Data element, which is preferred.

This replaces the existing booleanFilter Alpine Data object with a newBooleanFilter (ensuring backwards compatibility) for those with published views).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (ff38951) to head (3dc2089).
Report is 4 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2066      +/-   ##
=================================================
+ Coverage          88.04%   88.05%   +0.01%     
- Complexity          1934     1937       +3     
=================================================
  Files                184      184              
  Lines               4426     4430       +4     
=================================================
+ Hits                3897     3901       +4     
  Misses               529      529              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 2aeb882 into rappasoft:development Nov 17, 2024
9 checks passed
lrljoe added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: lrljoe <[email protected]>

* Remove Waiting For Tests

* Use CODECOV_TOKEN

* Fix styling

* Update phpdoc for boot (#2055)

* Update phpdoc for boot

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add test for No Columns defined - throws correct Exception (#2057)

* Add test for No Columns

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add Simple updatedSearch tests (#2058)

* Add Simple updatedSearch tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add test for FilterApplied Event being dispatched (#2059)

* Add test for FilterApplied being dispatched

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>

* Add updatedSelectedColumns test for Event (#2060)

* Add test for ColumnsSelected Event dispatch


* Apply Separate Tests

---------

Co-authored-by: lrljoe <[email protected]>

* Adjustment for DateRangeFilter (#2064)

* Adjust SessionStorageHelpersTest (#2065)

* FixSetDefaultPerPage (#2067)

* FixSetDefaultPerPage

* Update getDefaultPerPage to respect getPerPageAccepted

* Fix missing )

* Fix styling

* Add test fix

* Add final tests

---------

Co-authored-by: lrljoe <[email protected]>

* Fix BooleanColumn unexpected truthy behaviour (#2066)

* Fix BooleanColumn unexpected truthy behaviour

* Support previous iteration

* Update ChangeLog

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant