Skip to content

Remove getComponent #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove getComponent #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Views/Traits/Core/HasFooter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
} elseif ($callback instanceof Filter) {
return $callback->setFilterPosition('footer')->setGenericDisplayData($filterGenericData)->render();
} elseif (is_string($callback)) {
$filter = $this->getComponent()->getFilterByKey($callback);
$filter = $this->component->getFilterByKey($callback);

Check warning on line 81 in src/Views/Traits/Core/HasFooter.php

View check run for this annotation

Codecov / codecov/patch

src/Views/Traits/Core/HasFooter.php#L81 

Added line #L81 was not covered by tests

if ($filter instanceof Filter) {
return $filter->setFilterPosition('footer')->setGenericDisplayData($filterGenericData)->render();
Expand Down
2 changes: 1 addition & 1 deletion src/Views/Traits/Core/HasSecondaryHeader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
} elseif ($callback instanceof Filter) {
return $callback->setFilterPosition('header')->setGenericDisplayData($filterGenericData)->render();
} elseif (is_string($callback)) {
$filter = $this->getComponent()->getFilterByKey($callback);
$filter = $this->component->getFilterByKey($callback);

Check warning on line 80 in src/Views/Traits/Core/HasSecondaryHeader.php

View check run for this annotation

Codecov / codecov/patch

src/Views/Traits/Core/HasSecondaryHeader.php#L80 

Added line #L80 was not covered by tests

if ($filter instanceof Filter) {
return $filter->setFilterPosition('header')->setGenericDisplayData($filterGenericData)->render();
Expand Down
5 changes: 0 additions & 5 deletions src/Views/Traits/Helpers/ColumnHelpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@

trait ColumnHelpers
{
public function getComponent(): ?DataTableComponent
{
return $this->component;
}

public function hasFrom(): bool
{
return $this->from !== null;
Expand Down
Loading