Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 20, 2024

Removes the config.php from Test Coverage as it is unnecessary (as all methods are tested in other ways)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 748a9e9 into rappasoft:development Nov 20, 2024
7 checks passed
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (3f3918d) to head (27c1575).
Report is 1 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2080   +/-   ##
==============================================
  Coverage          88.15%   88.15%           
  Complexity          1945     1945           
==============================================
  Files                186      186           
  Lines               4441     4441           
==============================================
  Hits                3915     3915           
  Misses               526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

lrljoe added a commit that referenced this pull request Nov 21, 2024
## [v3.5.4] - 2024-11-21
### Bug Fixes
- Allow JSON and PHP type localisations by @lrljoe in #2071
- Allow lazy loading of tables by @lrljoe in #2072

### Testing
- RemoveConfigFileFromCoverage by @lrljoe in #2080
- Test for ViewComponentColumn - Cannot return non-array attributes  by @lrljoe in #2078
- BooleanFilter - Add Tests for Null in IsEmpty and Validate by @lrljoe in #2077
- Add Attributes Check For ViewComponentColumn by @lrljoe in #2076
- Add ViewComponentColumn label test  by @lrljoe in #2075
- Add ColorColumnTests by @lrljoe in #2074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant