Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 22, 2024

A basic improvement so that:

A new protected boolean:

  • $hasRunColumnSetup = false

On boot:

  • $columns Collection is created:
    • prependedColumns
    • columns()
    • appendedColumns

When attempting to getColumns(), validate whether $hasRunColumnSetup
If it has not run, validate/filter the Columns, and add the relevant fields/withs to the $builder

This change:

  • reduces the number of times that the logic checking different Column sources has to run
  • removes the requirement for builder to be instantiated before the WithColumns trait boots.
  • simplifies some future changes to improve the data flow

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 564c2f0 into rappasoft:development Nov 22, 2024
7 checks passed
@lrljoe lrljoe mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant