Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 16, 2024

Add Missing Test for getCustomSortingPillDirectionsLabel with invalid direction

        $column = Column::make('Name', 'name');
        $defaultString = __($this->basicTable->getLocalisationPath().'not_applicable');

        $this->assertSame('A-Z', $column->getCustomSortingPillDirectionsLabel('asc'));
        $this->assertSame('Z-A', $column->getCustomSortingPillDirectionsLabel('desc'));
        $this->assertSame($defaultString, $column->getCustomSortingPillDirectionsLabel('faulty_string'));

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (b2ddbb7) to head (d235860).

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2130      +/-   ##
=================================================
+ Coverage          90.47%   90.49%   +0.02%     
  Complexity          1945     1945              
=================================================
  Files                201      201              
  Lines               4388     4388              
=================================================
+ Hits                3970     3971       +1     
+ Misses               418      417       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 493959c into rappasoft:development Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant