Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 26, 2024

Changes:

  • Move Query related properties & methods into WithQuery from ComponentUtilities
  • Migrate ColumnSelect query string elements to new approach
  • Migrate HasQueryString elements into the WithQueryString trait
  • Migrate QueryString tests to use a base test case to standardise approach

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (ab35e6c) to head (149ca4b).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
...ore/QueryStrings/HasQueryStringForColumnSelect.php 66.66% 8 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2135      +/-   ##
=================================================
- Coverage          90.69%   90.53%   -0.17%     
- Complexity          1967     1980      +13     
=================================================
  Files                203      205       +2     
  Lines               4470     4488      +18     
=================================================
+ Hits                4054     4063       +9     
- Misses               416      425       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit eda4c5e into rappasoft:development Dec 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant