Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 31, 2024

This is a fix for where DefaultSort is set, but it is not displayed in the Column Sort, nor in the Sorting Pills area.

Needs further testing/assessment.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.51%. Comparing base (c67247b) to head (35cecf2).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
src/Traits/Configuration/SortingConfiguration.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2138      +/-   ##
=================================================
- Coverage          90.53%   90.51%   -0.02%     
- Complexity          1980     1983       +3     
=================================================
  Files                205      205              
  Lines               4488     4490       +2     
=================================================
+ Hits                4063     4064       +1     
- Misses               425      426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 1d991b2 into rappasoft:development Dec 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant