Skip to content

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 8, 2025

This PR separates the search methods into respective Traits

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 98.76543% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (a57de60) to head (8389d03).

Files with missing lines Patch % Lines
src/Traits/WithSearch.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2163      +/-   ##
=================================================
- Coverage          90.94%   90.93%   -0.01%     
- Complexity          1993     1994       +1     
=================================================
  Files                211      213       +2     
  Lines               4504     4500       -4     
=================================================
- Hits                4096     4092       -4     
  Misses               408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 6d7b59b into rappasoft:development Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant