Skip to content

Conversation

HussamAlhennawi
Copy link
Contributor

@HussamAlhennawi HussamAlhennawi commented Jan 14, 2025

Hi,

First of all thanks for this incredible package, great work.

This PR represents an implementation to enable setting the styles for column select (button and menu option checkbox) as a configuration through the following functions:

  • setColumnSelectButtonAttributes(...)
  • setColumnSelectMenuOptionCheckboxAttributes(...)

This is my first contribution to this package and of course, feedback is welcome.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

@lrljoe
Copy link
Collaborator

lrljoe commented Jan 16, 2025

Awesome! I will review this at the weekend and look to merge it if nothing stands out as an issue.

At first glance it looks fine however. Really appreciate the contribution!

This will be in the release after next however - as there's a ton of stuff ready to go that I need to release first. That's not to say that the subsequent release won't be very soon after the next one.

@lrljoe
Copy link
Collaborator

lrljoe commented Jan 16, 2025

Only thing that appears to be missing is tests. I'm happy to add these once merged in, as I also need to re-visit the
resources/views/components/tools/toolbar/items/column-select.blade.php

And tidy it up a bit.

@lrljoe lrljoe merged commit 7f2beaa into rappasoft:development Jan 16, 2025
8 checks passed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (6598b25) to head (edbaf69).
Report is 3 commits behind head on development.

Files with missing lines Patch % Lines
...Configuration/ColumnSelectStylingConfiguration.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2175      +/-   ##
=================================================
- Coverage          91.44%   91.32%   -0.12%     
- Complexity          1995     1999       +4     
=================================================
  Files                212      214       +2     
  Lines               4499     4509      +10     
=================================================
+ Hits                4114     4118       +4     
- Misses               385      391       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe mentioned this pull request Feb 27, 2025
9 tasks
lrljoe added a commit that referenced this pull request Feb 28, 2025
## [v3.7.0] - 2025-02-27

### Bug Fixes
- Filters urgent fixes - correct Filter Default QueryString by @lrljoe in #2188
- Fix Search Field in bootstrap by @yparitcher in #2183
- Add "after-tools" configurable area by @lrljoe in #2180

### New Features
- Add setFilterPillTitleAsHtml by @lrljoe in #2204
- Enable setting styles for sorting pills as a configuration by @HussamAlhennawi in #2179
- Enable setting styles for filter pills as a configuration by @HussamAlhennawi in #2178
- Enable setting styles for column select as a configuration by @HussamAlhennawi in #2175
- BulkActionTweaks - Adding default checkbox, customising attribute behaviours by @lrljoe in #2203
- Laravel v12 Support by @lrljoe in #2217

### Tweaks
- Tweak for text pill title by @lrljoe in #2206
- Tweak Return Types by @lrljoe in #2205
- Migrate Column/Filter Traits by @lrljoe in #2202
- Filter Rationalisation & Livewire Array Filter improvements by @lrljoe in #2191
- Move Filter View Traits by @lrljoe in #2189
- Filter Trait - Reorganization by @lrljoe in #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants