Skip to content

Conversation

HussamAlhennawi
Copy link
Contributor

Hi,

This PR represents an implementation to enable setting the styles for filter pills (item, reset button and reset all button) as a configuration through the following functions:

  • setFilterPillsItemAttributes(...)
  • setFilterPillsResetFilterButtonAttributes(...)
  • setFilterPillsResetAllButtonAttributes(...)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.15%. Comparing base (7f2beaa) to head (4f0c1c2).
Report is 5 commits behind head on development.

Files with missing lines Patch % Lines
.../Configuration/FilterPillsStylingConfiguration.php 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2178      +/-   ##
=================================================
- Coverage          91.32%   91.15%   -0.18%     
- Complexity          1999     2005       +6     
=================================================
  Files                214      216       +2     
  Lines               4509     4524      +15     
=================================================
+ Hits                4118     4124       +6     
- Misses               391      400       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe
Copy link
Collaborator

lrljoe commented Jan 18, 2025

I'll merge this in shortly, however I'll be making some modifications to it, as it should ideally use the centralised helper methods for managing the attributes.

@lrljoe lrljoe merged commit e58bfba into rappasoft:development Jan 18, 2025
9 of 10 checks passed
@lrljoe lrljoe mentioned this pull request Feb 27, 2025
9 tasks
lrljoe added a commit that referenced this pull request Feb 28, 2025
## [v3.7.0] - 2025-02-27

### Bug Fixes
- Filters urgent fixes - correct Filter Default QueryString by @lrljoe in #2188
- Fix Search Field in bootstrap by @yparitcher in #2183
- Add "after-tools" configurable area by @lrljoe in #2180

### New Features
- Add setFilterPillTitleAsHtml by @lrljoe in #2204
- Enable setting styles for sorting pills as a configuration by @HussamAlhennawi in #2179
- Enable setting styles for filter pills as a configuration by @HussamAlhennawi in #2178
- Enable setting styles for column select as a configuration by @HussamAlhennawi in #2175
- BulkActionTweaks - Adding default checkbox, customising attribute behaviours by @lrljoe in #2203
- Laravel v12 Support by @lrljoe in #2217

### Tweaks
- Tweak for text pill title by @lrljoe in #2206
- Tweak Return Types by @lrljoe in #2205
- Migrate Column/Filter Traits by @lrljoe in #2202
- Filter Rationalisation & Livewire Array Filter improvements by @lrljoe in #2191
- Move Filter View Traits by @lrljoe in #2189
- Filter Trait - Reorganization by @lrljoe in #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants