Skip to content

Tweak Return Types #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Tweak Return Types #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a40a72d
Tweak Return Types
lrljoe Feb 16, 2025
35cd35a
Tweak type
lrljoe Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/DataTransferObjects/Filters/FilterPillData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function getCustomResetButtonAttributes(): array

public function getIsAnExternalLivewireFilter(): int
{
return intval($this->isAnExternalLivewireFilter ?? false);
return intval($this->isAnExternalLivewireFilter ?? 0);
}

public function getSeparator(): string
Expand All @@ -68,17 +68,17 @@ public function getSeparator(): string

public function shouldUsePillsAsHtml(): int
{
return intval($this->renderPillsAsHtml ?? false);
return intval($this->renderPillsAsHtml ?? 0);
}

public function shouldUsePillsTitleAsHtml(): int
{
return intval($this->renderPillsTitleAsHtml ?? false);
return intval($this->renderPillsTitleAsHtml ?? 0);
}

public function shouldWatchForEvents(): int
{
return intval($this->watchForEvents ?? false);
return intval($this->watchForEvents ?? 0);
}

public function isPillValueAnArray(): bool
Expand Down
2 changes: 1 addition & 1 deletion src/View/Components/FilterPill.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class FilterPill extends Component

public function __construct(public string $filterKey, public FilterPillData $filterPillData)
{
$this->shouldWatch = $this->filterPillData->shouldWatchForEvents() ?? 0;
$this->shouldWatch = (bool) $this->filterPillData->shouldWatchForEvents();
}

public function render(): null|string|\Illuminate\Support\HtmlString|\Illuminate\Contracts\Foundation\Application|\Illuminate\Contracts\View\Factory|\Illuminate\Contracts\View\View
Expand Down
Loading