Skip to content

Conversation

da-mask
Copy link
Contributor

@da-mask da-mask commented Feb 20, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Calling the toggleMethod on a toggleable function on a BooleanColumn requires that the id is selected as part of the query, otherwise nothing is passed in. Took a bit of diving to work out what was going on, hopefully this may save someone some time.

@lrljoe lrljoe changed the base branch from master to development February 28, 2025 04:04
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (6598b25) to head (df4b622).
Report is 37 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2208   +/-   ##
==============================================
  Coverage          91.44%   91.44%           
  Complexity          1995     1995           
==============================================
  Files                212      212           
  Lines               4499     4499           
==============================================
  Hits                4114     4114           
  Misses               385      385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lrljoe
Copy link
Collaborator

lrljoe commented Feb 28, 2025

Awesome, to save me a few minutes, please could you add in a link to go to the placeholder for setAdditionalSelects:

datatable/available-methods#content-setadditionalselects

So that it makes it obvious how to add the "id" field in as an additional select via the configure() method

@lrljoe lrljoe merged commit c7817c7 into rappasoft:development Apr 20, 2025
10 checks passed
lrljoe added a commit that referenced this pull request May 3, 2025
* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Fix styling

* Update ChangeLog

* docs: add reminder of requirement to use toggle method (#2208)

Co-authored-by: Joe <[email protected]>

* Update IsNumericFilter.php (#2230)

* Link column fix (#2223) (#2224)

* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog

* Update IsNumericFilter.php

Fixes issues 2229

---------

Co-authored-by: Joe <[email protected]>

* Fix styling

* Boolean filter for bootstrap (#2244)

* Add BooleanFilter option for Bootstrap

* Add BS4 Support

* Update docs

* Fixes for livewire component column (#2245)

* Initial Commit

* Fix styling

* Initial Commit

* Fix styling

* Adjust test

* Fix styling

* Use test-livewire-column-component

* Additional Tests for LivewireComponentColumn

* Fix styling

* Add getContents Test

* TypeHint/PHPDoc Tidying (#2246)

* Fix broken typehints

* Minor tweaks to Footer/SecondaryHeader to ensure presence of callback prior to executing

* Fix styling

* PHPDoc additions

* Fix styling

* Update ChangeLog for TypeHintFixes

* Fix styling

* FilterPillData and StandardFilterPillData phpdocs

* Fix styling

* Add Wrapper Options to ArrayColumn (#2255)

* Add Wrapper Options to FlexCol

* Fix styling

* Moving getContents Back

* Fix styling

* Add Docs

* Add Wrapper Manual Tests

* Fix styling

* Update to test separator

* Fix styling

* Improved pagination UX (#2251)

* Link column fix (#2223) (#2224)

* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog

* Improved pagination UX

---------

Co-authored-by: Joe <[email protected]>

* Fixed collapsed function bug with tailwind CSS on mobile version (#2228)

* v3.7.2 updates (#2256)

---------

Co-authored-by: da-mask <[email protected]>
Co-authored-by: G4Zz0L1 <[email protected]>
Co-authored-by: Daniel Škopek <[email protected]>
Co-authored-by: CarlosChub27 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants