Fix: Add binary compatibility forwarder for EventStream.recover#150
Closed
nguyenyou wants to merge 1 commit intoraquo:masterfrom
Closed
Fix: Add binary compatibility forwarder for EventStream.recover#150nguyenyou wants to merge 1 commit intoraquo:masterfrom
nguyenyou wants to merge 1 commit intoraquo:masterfrom
Conversation
Only the recover method in EventStream is needed for caliban compatibility, as it only uses .map and .recover on EventStream.
c81cf3d to
b73aa29
Compare
Owner
|
Sorry, I don't think I'll be merging this after all. You've already worked around this locally, and nobody else has expressed interest in this. If I merge this, then yes, we'll get a bit of binary compatibility in v18 release, but then we'll have to break it again in the next release once we remove this forwarder (as I understand it). So it would just be delaying the breakage. Might as well be done with that now if it's not especially hurting anyone 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recoveronEventStreamFixes #149
Context
As diagnosed by @sjrd in this comment,
RecoverOps[+Self[+_], +A]hasSelfwithout the<: Observable[_]upper bound thatBaseObservablehas. Whenrecovermoved toRecoverOpsin 18.0.0-M3, the Scala.js IR method descriptor changed (erased return type went fromObservabletoObject), breaking binary compatibility for downstream libraries compiled against 17.x.The fix is minimal: only
EventStream.recoverneeds a forwarder, since caliban (the affected library) only calls.mapand.recoveronEventStream, and.mapis already overridden.Reproduction
https://github.com/nguyenyou/airstream-recover-bincompat-repro
Test plan
🤖 Generated with Claude Code