-
Notifications
You must be signed in to change notification settings - Fork 2k
configtxt/boot: Update arm_64bit flag #3903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6c8979
configtxt/boot: Update arm_64bit flag
tdewey-rpi 4270c31
Move Raspberry Pi 5 warning to start of block
tdewey-rpi 4835557
Suggested rewording from Nate
tdewey-rpi 6349bd0
Prune top-heavy NOTE
tdewey-rpi e82addc
Add CM4S
nathan-contino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add CM5 as well - everyone knows its coming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to avoid mentioning any potential products ahead of a formal announcement, especially if I've structured the text such that any new products could be trivially included in the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Tom in principle. But for my own edification: I assumed that CM5 wouldn't support 32-bit mode at all, just like Pi 5. So I don't think we need to add it here at release. Is that correct, @JamesH65 ? Or will CM5 support 32-bit mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's actually the SoC (and not the specific Model) that determines if it's capable of booting 32-bit kernel only (BCM2835, BCM2836), either 32- or 64-bit kernel (BCM2837, RP3A0, BCM2711), or 64-bit kernel only (BCM2712) ?
But (in general) we explicitly list the Models in documentation rather than SoCs, because people find it easier to identify their Model than to identify their SoC 🧦 😉