Skip to content

Conversation

@nllho
Copy link

@nllho nllho commented Nov 26, 2024

Some minor fixes that came up while reviewing this section for another issue!

@nllho nllho requested a review from nathan-contino November 26, 2024 19:49
Copy link
Contributor

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But we will likely have to revisit the family/series language in the future -- it seems other folks at the company have been using 'family' to denote a product with multiple generations, and 'series' for a single generation of a product (!!!)

@nathan-contino nathan-contino merged commit 447dbd4 into develop Nov 26, 2024
1 check passed
@nathan-contino nathan-contino deleted the update-rp2040 branch November 26, 2024 20:42
@lurch
Copy link
Contributor

lurch commented Nov 26, 2024

But we will likely have to revisit the family/series language in the future -- it seems other folks at the company have been using 'family' to denote a product with multiple generations, and 'series' for a single generation of a product (!!!)

That sounds like great content for the https://github.com/raspberrypi/style-guide/blob/master/style-guide.md !

@nathan-contino
Copy link
Contributor

ain't that the truth. @nllho , would you mind opening a PR in the style guide for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants