Make the Connect upgrade caveat more specific #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clowder
force-pushed
the
clowder-patch-1
branch
2 times, most recently
from
b5c8476 to
9f2b425
Compare
clowder
changed the title
clowder
force-pushed
the
clowder-patch-1
branch
from
9f2b425 to
ba2ecbd
Compare
lurch
reviewed
Apr 22, 2025
There was a problem hiding this comment.
"To upgrade in a" -> "To upgrade Connect in a" ?
"after the session is terminated." -> "after the parent session is terminated." ?
mudge
reviewed
Apr 23, 2025
This issue only effects the remote shell sessions, because they're subprocesses of `rpi-connectd` and terminated when it's restarted. Also it's possible to work around the issue using `screen`.
clowder
force-pushed
the
clowder-patch-1
branch
from
1f68def to
00c8774
Compare
mudge
approved these changes
Apr 23, 2025
lurch
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue only effects the remote shell sessions, because they're subprocesses of
rpi-connectdand terminated when it's restarted. Also it's possible to work around the issue usingscreen.