drm: rp1: rp1-dpi: Add "rgb_order" property (to match VC4 DPI)#6597
Conversation
|
I think this is correct, my only reticence (and the reason it's still a draft) is code size. |
| if (ret) | ||
| goto done_err; | ||
|
|
||
| dpi->rgb_order_override = -1; |
There was a problem hiding this comment.
My only comment is that this could potentially be defined as RP1DSPI_ORDER_UNCHANGED, and check for that by name instead of < 0 at line 423.
There was a problem hiding this comment.
It's copied from vc4_dpi.c (though in that instance the values were from a register field).
BTW I also toyed with encoding the lookup order more directly in the variable (values like 0x020100) to avoid the switch statement.
There was a problem hiding this comment.
vc4_dpi.c isn't always the best example, and there is no requirement to copy how it is implemented in the code, only the DT side.
There was a problem hiding this comment.
Added RP1DSI_ORDER_UNCHANGED as an explicit value, and re-worked the lookup to use bit-shifts (which makes both object and source code slightly smaller. That last & 3 is superstitious since the values are internal).
|
Tested on RGB666_CPADHI (Mode 6) and RGB666 (Mode 5) HATs; kmstest with all supported 4CCs over all values of rgb_order. The colours seemed to be going to the right places as far as I could see. Also tested RGB565 (Mode 2) and RGB888 (Mode 7) albeit without appropriate hardware, and the output looked plausible. |
|
Tested on my hardware as well. Verified rgb888 with rgb-order of brg and grb work as expected. |
As on VC4, the OF property overrides the order implied by media bus format. Only 4 of the 6 possible orders are supported. New add-on hardware designs should not rely on this "legacy" feature. Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
njhollinghurst
force-pushed
the
rp1-rgb-order
branch
from
7a24a97 to
0edb4d3
Compare
kernel: configs: add CONFIG_SND_SOC_WM8904=m See: raspberrypi/linux#6623 kernel: drm: rp1: rp1-dpi: Add rgb_order property (to match VC4 DPI) See: raspberrypi/linux#6597
kernel: configs: add CONFIG_SND_SOC_WM8904=m See: raspberrypi/linux#6623 kernel: drm: rp1: rp1-dpi: Add rgb_order property (to match VC4 DPI) See: raspberrypi/linux#6597
3 participants
As on VC4, the OF property overrides the order implied by media bus format. Only 4 of the 6 possible orders are supported. New add-on hardware designs should not rely on this "legacy" feature.
This is is an attempt to deal with #6505.
Not all combinations of DRM pixel format, bus format and rgb_order have been tested yet.