Add overclock support to the upstream SDHOST driver#6610
Merged
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom Jan 14, 2025
Merged
Add overclock support to the upstream SDHOST driver#6610pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
Conversation
Collaborator
Can we merge it to 6.12 first? Can be merged to 6.6 once the next apt kernel is out. |
Now that the upstream driver is overclockable, switch to using it in preference of the downstream driver (which can be deleted by a followup commit). Signed-off-by: Phil Elwell <phil@raspberrypi.com>
The principal differences between the downstream SDHOST driver and the version accepted upstream driver are that the upstream version loses the overclock support and DMA configuration via DT, but gains some tidying up (and maintenance by the upstream devs). Add the missing features (with the exception of the low-overhead logging) as a patch to the upstream driver. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Contributor
Author
|
Yes, that can work. I've updated the PR, then swapped the commit order to persuade GitHub to rerun the checks - it can be swapped back if preferred. |
Contributor
Author
|
Rebuilt against 6.12 and updated a 3B+ running a slightly dodgy SD card overclocked to 100MHz, which had then stepped the clock down to 66MHz until the errors stopped. The 3B+ survived the reboot, so it can't be too bad: |
Contributor
Author
|
YOLO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #6603, which has arrived a bit sooner than advertised. It should probably be kept away from any stable kernel releases for a while. Unless an overclock is specified it is just the standard upstream driver, but that has probably had much less testing than the current downstream version.