drm/vc4: Correct arithmetic for shifting between columns of SAND images#6730
Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.12.yfrom Mar 19, 2025
Merged
drm/vc4: Correct arithmetic for shifting between columns of SAND images#6730pelwell merged 1 commit intoraspberrypi:rpi-6.12.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
Collaborator
|
What about this line: linux/drivers/gpu/drm/vc4/vc4_plane.c Line 1519 in c5098b3 |
Contributor
|
A quick test on RPi5 shows that zooming the Interstellar trailer up to 1.10 works fine, but the display craps out with dlist errors when increasing to 1.11 zoom |
Contributor
Author
I was going to test Pi4 (which this line would affect), but checking the thread it had been reported as working fine there. |
Contributor
Author
|
OK, so it does affect Pi4 too, but it just doesn't crash. |
Commit 69dbba7 ("drm/vc4: Add algorithmic handling for SAND") lost a multiplication by the tile width when doing the pointer arithmetic for cropping off columns for vc6. Correct that computation. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
approved these changes
Mar 19, 2025
Contributor
|
Thanks, zooming on RPi4 looks fine now after the update. But RPi5 still has the dlist issue. Working: Zoom set to 1.10 Not working, zoom set to 1.11, dmesg shows dlist errors |
Collaborator
Yes. But this PR fixes a clear bug and so is worth merging. |
Contributor
|
Sure, I just noticed during testing that the dlist issue is still present and that the maximum working zoom seems to have changed from 1.20 before to 1.10 with this change and thought it's worth mentioning. |
Contributor
Author
|
As I wrote on Slack, I'm suspecting that the dlist issue is HVS underruns resulting in no EOF interrupts, and therefore no cleanup. That's nothing to do with this PR. On Raspberry Pi OS I was zooming across the full range whilst playing Interstellar on a Pi5 8GB (C1), and had no issues. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 25, 2025
kernel: fixup! dmaengine: dw-axi-dmac: Fixes for RP1 See: raspberrypi/linux#6729 kernel: drm/vc4: Correct arithmetic for shifting between columns of SAND images See: raspberrypi/linux#6730 kernel: Adding Pisound Micro kernel module based on rpi-6.12.y See: raspberrypi/linux#6731 kernel: Fix two more RP1 DMA bugs See: raspberrypi/linux#6734 kernel: dts: bcm2712-rpi: Add uart0_nodma See: raspberrypi/linux#6365
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Mar 25, 2025
kernel: fixup! dmaengine: dw-axi-dmac: Fixes for RP1 See: raspberrypi/linux#6729 kernel: drm/vc4: Correct arithmetic for shifting between columns of SAND images See: raspberrypi/linux#6730 kernel: Adding Pisound Micro kernel module based on rpi-6.12.y See: raspberrypi/linux#6731 kernel: Fix two more RP1 DMA bugs See: raspberrypi/linux#6734 kernel: dts: bcm2712-rpi: Add uart0_nodma See: raspberrypi/linux#6365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 69dbba7 ("drm/vc4: Add algorithmic handling for SAND") lost a multiplication by the tile width when doing the pointer arithmetic for cropping off columns for vc6.
Correct that computation.
@popcornmix - fixes your Kodi zooming on Pi5.