Skip to content

media: i2c: imx415: Correct hmax_min values for 891Mbps/lane #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 2 commits into from
Apr 2, 2025
Merged

media: i2c: imx415: Correct hmax_min values for 891Mbps/lane #6750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f267ff9
media: i2c : imx415: Correct hmax_min values for 891Mbps/lane
6by9 Mar 31, 2025
615a920
dtoverlays: imx415: Add an override for 37.125MHz clock
6by9 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions arch/arm/boot/dts/overlays/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2873,6 +2873,9 @@ Params: addr Set I2C address of sensor. Valid values are
cam0 Adopt the default configuration for CAM0 on a
Compute Module (CSI0, i2c_vc, and cam0_reg).
vcm Enable ad5398 VCM associated with the sensor.
clk-37125 Alternative to clock-frequency=37125000 and
link-frequency=445500000 for Waveshare modules
with 37.125MHz clock sources.


Name: imx462
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/boot/dts/overlays/imx415-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@
<&cam_node>,"lens-focus:0=", <&vcm>;
clock-frequency = <&cam_clk>, "clock-frequency:0";
link-frequency = <&cam_endpoint>,"link-frequencies#0";
clk-37125 = <&cam_endpoint>,"link-frequencies#0=445500000",
<&cam_clk>, "clock-frequency:0=37125000";
4lane = <0>, "+201+202";
};
};
Expand Down
8 changes: 5 additions & 3 deletions drivers/media/i2c/imx415.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ static const struct imx415_mode supported_modes[] = {
},
{
.lane_rate = 891000000,
.hmax_min = { 1100, 550 },
.hmax_min = { 2200, 1100 },
.reg_list = {
.num_of_regs = ARRAY_SIZE(imx415_linkrate_891mbps),
.regs = imx415_linkrate_891mbps,
Expand Down Expand Up @@ -725,6 +725,7 @@ static int imx415_s_ctrl(struct v4l2_ctrl *ctrl)
* Deliberately fall through as exposure is set based on VMAX
* which has just changed.
*/
ctrl = sensor->exposure;
fallthrough;
case V4L2_CID_EXPOSURE:
/* clamp the exposure value to VMAX. */
Expand Down Expand Up @@ -752,10 +753,11 @@ static int imx415_s_ctrl(struct v4l2_ctrl *ctrl)
break;

case V4L2_CID_HBLANK:
return cci_write(sensor->regmap, IMX415_HMAX,
(format->width + ctrl->val) /
ret = cci_write(sensor->regmap, IMX415_HMAX,
(format->width + ctrl->val) /
IMX415_HMAX_MULTIPLIER,
NULL);
break;

default:
ret = -EINVAL;
Expand Down
Loading