drivers: pci: hailo: Fix kernel warning when calling find_vdma()#6765
drivers: pci: hailo: Fix kernel warning when calling find_vdma()#6765naushir merged 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
Calling this function without holding the mmap_read_lock causes the kernel to throw an error message, spamming the dmesg logs when running the Hailo hardware. Fix it by adding the approprite lock/unlock functions around find_vdma(). Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
The formatting for this patch is all messed and will fail the check, but matches the original source code from Hailo. |
|
Let's hold off from merging this until Hailo have a change to review - I've pinged them already. |
kernel: Added waveshare 7.0inch h dsi screen support See: raspberrypi/linux#6764 kernel: drivers: pci: hailo: Fix kernel warning when calling find_vdma() See: raspberrypi/linux#6765 kernel: configs: Make the RTL8152 driver a module See: raspberrypi/linux#6768
kernel: Added waveshare 7.0inch h dsi screen support See: raspberrypi/linux#6764 kernel: drivers: pci: hailo: Fix kernel warning when calling find_vdma() See: raspberrypi/linux#6765 kernel: configs: Make the RTL8152 driver a module See: raspberrypi/linux#6768
|
Unfortunately, while this fix silences the dmesg spamming, but it causes the hailo driver to hang after a minute or ten. [HailoRT] [error] CHECK failed - Waiting for async job to finish has failed with timeout (1000ms) And the kernel: |
|
@tsailerddln what are you running to cause this error? I'll try to reproduce this on my end. EDIT: It might be useful to try out the change in #6868 to see if it helps improve your stability. |
kernel: drivers: pci: hailo: Fix kernel warning when calling find_vdma() See: raspberrypi/linux#6765
kernel: drivers: pci: hailo: Fix kernel warning when calling find_vdma() See: raspberrypi/linux#6765
Calling this function without holding the mmap_read_lock causes the kernel to throw an error message, spamming the dmesg logs when running the Hailo hardware.
Fix it by adding the approprite lock/unlock functions around find_vdma().