Add extern "C" to isr_usbctrl in dev_lowlevel #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterharperuk
approved these changes
Jan 22, 2024
lurch
reviewed
Jan 22, 2024
peterharperuk
requested changes
Jan 22, 2024
|
I'm not sure I understand why/how are you trying to compile this example as C++.(or what you mean by it). |
I initially saved the file as .cpp to modify it in a more familiar language (not realizing isr_usbctrl is a special function). I suspect other developers may also attempt to unsuccessfully incorporate isr_usbctrl into C++ code. |
|
Is there any update on this pr? I have already made the requested changes. |
|
Seems fine to me |
peterharperuk
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USB dev_lowlevel example silently fails in C++ because
isr_usbctrlis name-mangled and therefore not registered as an interrupt handler. This PR addsextern "C"to use C linkage for this function and allow compiling as C++.It is certainly not the prettiest, but it is necessary for correct behavior (with C++ linkage, none of the host's packets are responded to and the device is useless). The alternative to this is to manually specify
irq_set_exclusive_handler, probably withinusb_device_init. The pico-sdk advertises itself as C/C++, so C++ compatibility should be taken into consideration in its examples.