Check rows before running hello_otp example #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
approved these changes
Sep 27, 2024
lurch
reviewed
Sep 30, 2024
| } | ||
| for (int i=0; i < sizeof(initial_data); i++) { | ||
| if (initial_data[i] != 0) { | ||
| printf("ERROR: This example requires empty OTP rows to run - change the ecc_row and raw_row variables to an empty row and recompile\n"); |
There was a problem hiding this comment.
Minor nitpick: I wonder if "to an empty row" should have been "to empty rows", in case people misinterpret "change the ecc_row and raw_row variables to an empty row" to mean "set them to the same empty row"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the OTP rows being used for the hello_otp example are 0 before the example starts, else the example will throw other errors. This was prompted by #554, so it will now throw an error in that case explaining that the rows need to be changed.