Some README and example cleanup #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
possibly time for some @lurch script magic! |
lurch
reviewed
Jul 24, 2025
lurch
reviewed
Jul 24, 2025
lurch
reviewed
Jul 24, 2025
Contributor
Hahaha, if only I had more spare time 😢 |
will-v-pi
reviewed
Jul 25, 2025
Contributor
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
Missed a couple (assuming the intention is that names in README should match TARGET names, which I agree with)
Also, while cleaning up, could you delete the space after add_executable before the bracket at the top of pio/ir_nec/ir_loopback/CMakeLists.txt (currently says add_executable (pio_ir_loopback ..., would be better as add_executable(pio_ir_loopback ...)
Co-authored-by: will-v-pi <[email protected]>
will-v-pi
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the PIO examples listed in the README did not match the actual name of the executable, so cleaning that up.
Also there was a use of a non-interface library which was arguably incorrect, and certainly not, i think, worth introducing there