WIP: Firmware compression #1113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build changes needed for firmware compression. Enhance cyw43_write_bytes to allow us to use a src pointer part way through spid_buf which is used as a temorary buffer for firmware decompression Depends on georgerobotics/cyw43-driver#44 Fixes raspberrypi#909
Include the file where panic is defined
|
Marked as WIP as we have to wait for the driver changes to be submitted |
lurch
reviewed
Dec 4, 2022
| hardware_pio | ||
| hardware_dma | ||
| hardware_exception | ||
| pico_uzlib |
There was a problem hiding this comment.
Should pico_uzlib be included only if ${CYW43_DECOMPRESS_FIRMWARE} is set? 🤷
There was a problem hiding this comment.
I would expect it to have no effect if it's unused?
|
Closing this - replaced with #1310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to the sdk to support cyw43 firmware compression
Driver changes here georgerobotics/cyw43-driver#44