Export linker scripts in the bazel build. #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the rp2024 and rp2350 linker scripts available in downstream projects bazel builds.
armandomontanez
suggested changes
Sep 23, 2024
armandomontanez
approved these changes
Sep 23, 2024
|
nit: Commit-message says "rp2024" instead of "rp2040", but that probably doesn't matter. |
fixed. |
|
You edited the PR message, not the commit message 😉 But like I said, this doesn't really matter. |
sorry, should have said "sort of fixed" :) Fixing up old commit message is a bit of a pain, and I don't know if this repo allows force commits. |
kilograham
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export linker scripts in the bazel build.
Make the rp2040 and rp2350 linker scripts available in downstream projects bazel builds.