Avoid setting an alarm in the past #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
previously approved these changes
Sep 25, 2024
peterharperuk
commented
Sep 25, 2024
andygpz11
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
This looks good and makes sense to me.
@kilograham please can you review and merge to develop if happy?
It would be useful to be able to pull this.
Thanks
Remove local "now" variable.
peterharperuk
dismissed stale reviews from andygpz11 and kilograham
via
67f4ad9
|
Perhaps Graham will merge it 71 minutes in the future 😆 |
kilograham
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1953