Remove Segger RTT from pico-btstack #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Oct 23, 2024
|
Ahhh, looks like this PR is a consequence of #1411 |
|
I don't know much about cmake / compilers / linkers / etc. but does this change potentially mean that a project using |
Good point. Let me check. later: groan - you get a linker error :( |
lurch
reviewed
Oct 23, 2024
We now have this in the SDK so adding it again in pico-btstack leads to link errors. But it's possible to use the btstack RTT functionality by defining ENABLE_SEGGER_RTT=1, and if we're not using pico_stio_rtt we still need to add the btstack RTT source.
peterharperuk
force-pushed
the
segger_fix
branch
from
99c602f to
7d2a27d
Compare
kilograham
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have this in the SDK so adding it again in pico-btstack leads to link errors.