Move CYW43-related PICO_CONFIG lines to cyw43_driver.h #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
previously approved these changes
Nov 4, 2024
peterharperuk
requested changes
Nov 4, 2024
I'm happy to take out the Pico-specific values from |
|
I don't really like these defines in cyw43_driver.h. I'd rather remove the PICO_CONFIG lines completely if they're causing a problem. Although this sounds like a tooling defect to me. |
lurch
force-pushed
the
move_cyw43_pico_configs
branch
from
2e8ae23 to
2499769
Compare
|
I've just force-pushed an updated commit, which removes the defines from |
peterharperuk
approved these changes
Nov 5, 2024
ta |
lurch
added a commit
that referenced
this pull request
Nov 11, 2024
- Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries - Fix a silly typo I made in #2002 - Enhance config-extraction scripts to catch similar typos in future
lurch
added a commit
that referenced
this pull request
Nov 12, 2024
- Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries - Fix a silly typo I made in #2002 - Enhance config-extraction scripts to catch similar typos in future
kilograham
pushed a commit
that referenced
this pull request
Nov 19, 2024
- Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries - Fix a silly typo I made in #2002 - Enhance config-extraction scripts to catch similar typos in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1982 - I'm afraid that I didn't think to check at the time, but the
tools/extract_configs.pyscript was getting upset that there were duplicate PICO_CONFIG entries in different files. So this PR fixes that.