Skip to content

Conversation

@lurch
Copy link
Contributor

@lurch lurch commented Nov 20, 2024

Looks like this change accidentally got omitted from #1926

Looks like this change accidentally got omitted from #1926
@lurch lurch requested a review from kilograham November 20, 2024 00:01
Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge for completeness; though i think i'm going to remove all the CYW43_ related CMake vars, since they really belong just in the board header IMHO

@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
@kilograham kilograham merged commit c4b55f6 into develop Nov 20, 2024
8 checks passed
@kilograham kilograham deleted the lurch-patch-2 branch November 20, 2024 01:12
@lurch
Copy link
Contributor Author

lurch commented Nov 20, 2024

though i think i'm going to remove all the CYW43_ related CMake vars

I'm not gonna complain (I'm still not sure why some things are header defines and others are CMake vars), but pulling in @peterharperuk as IIRC he added these CYW43 CMake vars...

Is it so that you can add e.g. -DCYW43_PIO_CLOCK_DIV_FRAC8=4 to the cmake command-line to easily override the value set in the board header file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants