Skip to content

make panic loop back to breakpoint FWIW, and remove spurious header #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Remove unnecessary check in pio_encode_sideset_opt
merged 1 commit into from
Nov 21, 2024
Merged

make panic loop back to breakpoint FWIW, and remove spurious header #2062

merged 1 commit into from
Nov 21, 2024
+4 −5

Conversation

@kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham mentioned this pull request Nov 20, 2024
Closed
@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
Wren6991
Wren6991 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Wren6991 Wren6991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. bkpt and ebreak do not "return" except when under debugger control anyway, so this just avoids the case where you continue and the debug prompt goes quiet.

@kilograham
Copy link
Contributor Author

kilograham commented Nov 21, 2024 •
edited
Loading

yup; i just noticed it in passing, and thought "why not" ;-)

@kilograham kilograham merged commit 31c1be5 into develop Nov 21, 2024
8 checks passed
@kilograham kilograham deleted the panic branch November 21, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wren6991 Wren6991 Wren6991 approved these changes

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

@will-v-pi will-v-pi Awaiting requested review from will-v-pi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kilograham @Wren6991