Skip to content

fix incorrect disassembly of MOV rx_fifo instructions #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix incorrect disassembly of MOV rx_fifo instructions #2067

merged 1 commit into from
Nov 20, 2024

Conversation

@kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
@kilograham
Copy link
Contributor Author

fixes #1961

will-v-pi
will-v-pi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after reading up on the assembler syntax)

@kilograham kilograham merged commit 06a244b into develop Nov 20, 2024
8 checks passed
@kilograham kilograham deleted the pioasm_mov_rxfifo branch November 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

@lurch lurch Awaiting requested review from lurch

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kilograham @will-v-pi