-
Couldn't load subscription status.
- Fork 1.1k
Update documented max PIN values, to accomodate RP2350B #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I know the old max was incorrect in some places, but I'm not sure in terms of helping the user that using Still on the fence though so open to thoughts (cc @liamfraser @will-v-pi @peterharperuk) |
|
Yes, it's a bit techy. What's a bank anyway? |
I don't know if what I've added here is any more "techy" than anything else in section 5.1 of https://datasheets.raspberrypi.com/pico/raspberry-pi-pico-c-sdk.pdf ? 🤔
I think it's a building where you used to get money from, before everything became card-only 💳 |
well most of those actually refer to other configuration values whereas NUM_BANK0_GPIOS is a bit of an internal thing. we are a bit more conversational on others, e.g "1 on RP2350", so I'd say either "highest GPIO number", or "47 on RP2350B, 31 otherwise" |
|
29 if you are being pedantic edit: not pedantic actually, accurate (except in some cases - e.g. PIO where it is actually 32) |
|
Thanks for the suggestion - I'm much happier with something specific like "47 on RP2350B, 31 otherwise" than with something vague like "highest GPIO". (That change has been pushed) |
|
presumably we can't have a comma in the middle of the max value though (oops) |
|
maybe / instead of , |
132f15d to
28ba3cc
Compare
Yes we can, the hand-written parser for this is "clever" 😂 (and I also tested before submitting the PR) |
No description provided.