Skip to content

Conversation

@kilograham
Copy link
Contributor

@kilograham kilograham commented Nov 23, 2024

These can be specified via board header or target_compile_definitions

@kilograham kilograham added this to the 2.1.0 milestone Nov 23, 2024
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ok. If you're removing them, wouldn't it be better to delete them?

@kilograham
Copy link
Contributor Author

yeah, i decided to leave them for now in case we want them back

@kilograham kilograham merged commit 5f607a9 into develop Nov 24, 2024
8 checks passed
@kilograham kilograham deleted the remove_cmake_opts_for_cyw43 branch November 24, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants