Skip to content

Release the lock in mbedtls_sha256_free if it was not released already #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Release the lock in mbedtls_sha256_free if it was not released already #2105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c7551
Release the lock in mbedtls_sha256_free if it was not released alread…
Nov 27, 2024
07222ae
addres lock release API comment
Nov 27, 2024
3b3155b
Fix description of pico_sha256_cleanup
peterharperuk Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/rp2_common/pico_mbedtls/pico_mbedtls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ void mbedtls_sha256_init(__unused mbedtls_sha256_context *ctx) {
}

void mbedtls_sha256_free(__unused mbedtls_sha256_context *ctx) {
if (ctx->locked) {
pico_sha256_unlock(ctx);
}
}

int mbedtls_sha256_starts_ret(mbedtls_sha256_context *ctx, int is224) {
Expand Down
10 changes: 10 additions & 0 deletions src/rp2_common/pico_sha256/include/pico/sha256.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,16 @@ typedef struct pico_sha256_state {
size_t total_data_size;
} pico_sha256_state_t;

/*! \brief Release the internal lock on the SHA256 hardware
* \ingroup pico_sha256
*
* Release the internal lock on the hardware.
* Fails if the internal lock was not claimed.
*
* @param state A pointer to a pico_sha256_state_t instance
*/
void __weak pico_sha256_unlock(pico_sha256_state_t *state);

/*! \brief Start a SHA-256 calculation returning immediately with an error if the SHA-256 hardware is not available
* \ingroup pico_sha256
*
Expand Down