Support multiple .pio file in pico_generate_pio_header #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
approved these changes
Jan 20, 2025
will-v-pi
pushed a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1448
This PR changed code in CMake function
pico_generate_pio_header. Specifically:PIOthat was used to fetch PIO assembler filepico_generate_pio_header_UNPARSED_ARGUMENTSvariable that was created during CMake argument parsing is used instead, extracting every .pio file that was possibly specifiedSelf-test with
messageuncommented:Configure:
Build: