Fix semicolon in makefsdata.py #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple semicolon that breaks the file otherwise
peterharperuk
approved these changes
Feb 6, 2025
|
Easy mistake to make, when you're writing Python code to generate C code 😆 |
lurch
approved these changes
Feb 11, 2025
will-v-pi
pushed a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Mar 20, 2025
Simple semicolon that breaks the file otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple semicolon that breaks the file otherwise (it used to break my project but it doesn't anymore for some reason)
There is no associated issue for this, but no semi colon should be at the end of an instruction line in Python.