rp2350/pad_checksum: fix set cpu #2335
Conversation
|
|
||
| # try: | ||
| with open(args.ofile, "w") as ofile: | ||
| ofile.write("// Padded and checksummed version of: {}\n\n".format(args.ifile)) |
There was a problem hiding this comment.
Perhaps this "and checksummed" file-comment is also misleading, as there's a code-comment a few lines above saying "No CRC..." ?
Also, looks like the --seed argument is entirely unused by the RP2350 version of this script? 🤔 (Ahhh, but perhaps it's needed for CLI-compatibility with the RP2040 version)
|
After further investigation, it appears like this entire script is completely misleading, based on chapter 5.9.5 of the RP2350 documentation the boot2 checksum is not needed for the rp2350:
I am not really sure how to proceed with this PR, wouldn't it make sense to completely get rid of that script based on the fact that this isn't something the pico2 actually needs? |
|
Closing this PR as the issue appears bigger than was expected in the scope of this PR, see issue comments |
3 participants
See #2334
This PR should hopefully fix the incorrect cpu for the rp2350 in the pad_checksum function.