Pico runtime skip init all #2466
Conversation
kilograham
force-pushed
the
pico_runtime_skip_init_all
branch
from
2dc9e37 to
eb77caf
Compare
kilograham
force-pushed
the
pico_runtime_skip_init_all
branch
from
eb77caf to
95acddd
Compare
|
|
||
| // --------------------------------------------------------------------------------------- | ||
| // Non-boot core eset of bootrom state, not needed if only using core 0 not used on RP2040 | ||
| // Non-boot core reset of bootrom state, not needed if only using core 0 not used on RP2040 |
There was a problem hiding this comment.
Should there be a comma after "core 0" here, to avoid this being misread as "core 0 not used on RP2040" ?
| #endif | ||
| #else |
There was a problem hiding this comment.
With so many #endifs and #elses all over the place, it's pretty hard to see how things line up. Maybe some judicious
#endif // PICO_RUNTIME_INIT_FUNC
style comments would make this code slightly easier to read?
|
|
||
| void runtime_run_initializers(void); | ||
| void runtime_run_per_core_initializers(void); | ||
| // PICO_CONFIG: PICO_RUNTIME_SKIP_INIT_ALL, Skip calling of `runtime_init_` functions during runtime init, type=bool, default=0, group=pico_runtime_init |
There was a problem hiding this comment.
So presumably this "overrides" e.g. PICO_RUNTIME_SKIP_INIT_POST_CLOCK_RESETS ?
|
P.S. I just did a Is that intentional? |
|
Why is this needed? |
Good question; it is a bit of a hack, and i was on the fence. you pushed me off - i will remove them by updating the linker script in the encrypted bootloader |
|
It wasn't a criticism. I was just wondering |
3 participants
No description provided.